This repository has been archived by the owner on Oct 13, 2023. It is now read-only.
[ART-5863] closure for Real Time team when OCP ships a kernel-rt #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* clarify tracker issues vs jira bugs * break down some long methods * reverse "if not: else:" logic
vfreex
reviewed
Aug 9, 2023
| @@ -303,10 +287,10 @@ def _new_jira_fields_from_bug(bug: Bug, ocp_target_version: str, kmaint_tracker: | |||
| is_flag=True, | |||
| default=False, | |||
| help="Update summary, description, etc for already cloned Jira bugs. Must be used with --clone") | |||
| @click.option("--comment", | |||
| @click.option("--update-tracker", | |||
There was a problem hiding this comment.
We need to update aos-cd-jobs for the new option name.
There was a problem hiding this comment.
sosiouxme
force-pushed
the
20230706-kernel-rt-closeout
branch
from
0ab88cc
to
ab39f32
Compare
* add logic both when searching for bugs to clone and when closing them out to also close, comment, and link advisories for related KMAINT trackers * expand --comment flag to --update-tracker flag * extract/expand more common logic to early_kernel.py
sosiouxme
force-pushed
the
20230706-kernel-rt-closeout
branch
from
ab39f32
to
a8c0e93
Compare
sosiouxme
changed the title
|
/lgtm |
|
moving over to openshift-eng/art-tools#9 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... although it's really for any early kernel releases. This now follows up on trackers when we ship kernels (previously only cloned bugs were managed to completion). Trackers get links to the advisories that shipped their content, comments on the same, and closure.
I did some dry runs, and then live runs scoped to https://issues.redhat.com/browse/KMAINT-59 (see advisory link and comment there)